Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): Better docs for big chunk of schema stuff #25503

Merged
merged 4 commits into from
Aug 13, 2020
Merged

feat(docs): Better docs for big chunk of schema stuff #25503

merged 4 commits into from
Aug 13, 2020

Conversation

freiksenet
Copy link
Contributor

New docs for big chunk of schema stuff. sift docs need to be fully rewritten / changed to node-model docs. Inference stuff will be re-written by Vlad.

Description

Documentation

Related Issues

@freiksenet freiksenet added type: documentation An issue or pull request for improving or updating Gatsby's documentation status: needs docs review Pull request related to documentation waiting for review labels Jul 3, 2020
@freiksenet freiksenet requested review from a team as code owners July 3, 2020 12:43
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 3, 2020
@gatsby-cloud-staging
Copy link

gatsby-cloud-staging bot commented Jul 3, 2020 •
edited
Loading

Gatsby Cloud Build Report

gatsby-master

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 16m

Performance

Lighthouse report

Metric Score
Performance 💚 92
Accessibility 🔶 87
Best Practices 💚 93
SEO 🔶 73

🔗 View full report

@freiksenet freiksenet removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 3, 2020
vladar
vladar reviewed Jul 6, 2020
View reviewed changes
Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description of this process looks correct to me 👍

@AishaBlake AishaBlake removed the status: needs docs review Pull request related to documentation waiting for review label Jul 9, 2020
@freiksenet
Copy link
Contributor Author

freiksenet commented Jul 14, 2020 •
edited
Loading

@AishaBlake Does removing the label means it's good to merge or do you want to review it more?

@AishaBlake
Copy link

Really sorry for the delay, @freiksenet! Removing the label just means it's been triaged.

AishaBlake
AishaBlake suggested changes Jul 21, 2020
View reviewed changes
Copy link

@AishaBlake AishaBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of questions but most of these suggestions are missing words or typos. I think it reads clearly. Could you also add redirects for the renamed pages, please?

docs/docs/schema-root-fields.md Outdated Show resolved Hide resolved
docs/docs/schema-root-fields.md Outdated Show resolved Hide resolved
docs/docs/schema-root-fields.md Outdated Show resolved Hide resolved
docs/docs/schema-root-fields.md Outdated Show resolved Hide resolved
docs/docs/schema-root-fields.md Outdated Show resolved Hide resolved
docs/docs/schema-generation.md Outdated Show resolved Hide resolved
docs/docs/schema-generation.md Outdated Show resolved Hide resolved
docs/docs/schema-generation.md Outdated Show resolved Hide resolved
docs/docs/schema-generation.md Outdated Show resolved Hide resolved
docs/docs/schema-generation.md Outdated Show resolved Hide resolved
@freiksenet
feat(docs): Better docs for big chunk of schema stuff
10f1713 
Remove stale links

Apply suggestions from code review

Co-authored-by: Yogi <me@yogi.codes>

Apply suggestions from code review

Co-authored-by: Aisha Blake <aisha@gatsbyjs.com>

Rephrased mapping and added redirects
@freiksenet
Copy link
Contributor Author

@AishaBlake Thanks a lot for the review! I've fixed/accepted issues that you've raised, added redirects and rebased. It's now ready for re-review and a merge.

@freiksenet freiksenet requested a review from AishaBlake July 28, 2020 09:27
@freiksenet freiksenet dismissed a stale review July 28, 2020 09:27

Changes made.

@gatsby-cloud-staging
Copy link

gatsby-cloud-staging bot commented Jul 28, 2020 •
edited
Loading

Gatsby Cloud Build Report

gatsby

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 3h

Performance

Lighthouse report

Metric Score
Performance 💚 93
Accessibility 💚 100
Best Practices 💚 100
SEO 🔶 76

🔗 View full report

@AishaBlake
Copy link

Thanks, @freiksenet! I see the linter is picking up on a few things. If you get to this before me, would you mind fixing those? If not, I'll take care of them. This is one of the first things on my "to review" list for next week.

@freiksenet
Copy link
Contributor Author

@AishaBlake Fixed the linter issues now :)

@gatsby-cloud
Copy link

gatsby-cloud bot commented Aug 3, 2020 •
edited
Loading

Gatsby Cloud Build Report

client-only-paths

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 25s

Performance

Lighthouse report

Metric Score
Performance 💚 100
Accessibility 🔶 85
Best Practices 💚 100
SEO 🔶 70

🔗 View full report

@gatsby-cloud
Copy link

gatsby-cloud bot commented Aug 3, 2020 •
edited
Loading

Gatsby Cloud Build Report

using-styled-components

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 27s

Performance

Lighthouse report

Metric Score
Performance 💚 100
Accessibility 💚 90
Best Practices 💚 100
SEO 💚 90

🔗 View full report

@gatsby-cloud
Copy link

gatsby-cloud bot commented Aug 3, 2020 •
edited
Loading

Gatsby Cloud Build Report

using-reach-skip-nav

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 21s

Performance

Lighthouse report

Metric Score
Performance 💚 100
Accessibility 💚 100
Best Practices 💚 100
SEO 🔶 82

🔗 View full report

@gatsby-cloud
Copy link

gatsby-cloud bot commented Aug 3, 2020 •
edited
Loading

Gatsby Cloud Build Report

gatsby

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 23m

AishaBlake
AishaBlake approved these changes Aug 13, 2020
View reviewed changes
Copy link

@AishaBlake AishaBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Thanks so much for your patience, @freiksenet!!

@AishaBlake AishaBlake merged commit aa26bc2 into master Aug 13, 2020
This was referenced Aug 14, 2020
Closed
Merged
Merged
Closed
@LekoArts LekoArts deleted the new-schema-docs branch November 9, 2020 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladar vladar vladar left review comments

@AishaBlake AishaBlake AishaBlake approved these changes

Assignees

@vladar vladar

Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@freiksenet @AishaBlake @vladar